Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. #30409

Merged
merged 4 commits into from
Jan 5, 2022
Merged

bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. #30409

merged 4 commits into from
Jan 5, 2022

Conversation

methane
Copy link
Member

@methane methane commented Jan 5, 2022 •
edited by miss-islington
Loading

https://bugs.python.org/issue46236

Automerge-Triggered-By: GH:pablogsal

@methane methane added needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 5, 2022
pablogsal
pablogsal approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the quick fix, @methane!

@miss-islington
Copy link
Contributor

@methane: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 46e4c25 into python:main Jan 5, 2022
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2022
@methane @miss-islington
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (pythonGH-…
4a3b386 
…30409)

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 5, 2022
@bedevere-bot
Copy link

GH-30420 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jan 5, 2022
@miss-islington @methane
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (GH-30409)
da8be15 
Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)

Co-authored-by: Inada Naoki <[email protected]>
@larryhastings larryhastings mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@sweeneyde sweeneyde sweeneyde left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@methane @miss-islington @bedevere-bot @pablogsal @sweeneyde @kumaraditya303 @the-knights-who-say-ni